Issue 72730043: code review 72730043: go.tools/go/types: enable incremental adding of package...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72730043: code review 72730043: go.tools/go/types: enable incremental adding of package... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by gri

Modified:
11 years, 3 months ago

Reviewers:
adonovan

CC:
adonovan, golang-codereviews

Visibility:
Public.

Description

go.tools/go/types: enable incremental adding of package files With this CL, it is now possible to type-check additional package files to an already type-checked package through repeated calls to Checker.Files. Fixes issue 7114.

Patch Set 1 #

Patch Set 2 : diff -r 06b02dc5eabc https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 06b02dc5eabc https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 06b02dc5eabc https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 06b02dc5eabc https://code.google.com/p/go.tools #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -30 lines)			Patch
M	go/types/api_test.go	View	1 2	2 chunks	+25 lines, -0 lines	0 comments	Download
M	go/types/check.go	View	1 2 3	3 chunks	+14 lines, -9 lines	0 comments	Download
M	go/types/decl.go	View	1 2	4 chunks	+29 lines, -16 lines	0 comments	Download
M	go/types/resolver.go	View	1 2	3 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 3 months ago (2014-03-10 22:18:37 UTC) #1

adonovan

On 2014/03/10 22:18:37, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...

11 years, 3 months ago (2014-03-10 22:25:38 UTC) #2

gri

11 years, 3 months ago (2014-03-10 22:26:09 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=52b260732187&repo=tools ***

go.tools/go/types: enable incremental adding of package files

With this CL, it is now possible to type-check additional
package files to an already type-checked package through
repeated calls to Checker.Files.

Fixes issue 7114.

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/72730043

Expand All Messages | Collapse All Messages