Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159)

Issue 72720043: Improve attachment handling using redirect on list root folder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Tanmay Vartak
Modified:
10 years ago
Reviewers:
ejona, pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

Improve attachment handling using redirect on list root folder

Patch Set 1 #

Total comments: 12

Patch Set 2 : with code review comments implemented #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -6 lines) Patch
M src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java View 1 4 chunks +67 lines, -6 lines 2 comments Download
M test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java View 1 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Tanmay Vartak
10 years ago (2014-03-08 00:48:11 UTC) #1
ejona
https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2112 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2112: String listRedirectLocation= httpClient.getRedirectLocation( Space before = https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2130 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2130: // ...
10 years ago (2014-03-08 01:31:34 UTC) #2
pjo
Thank you. https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2112 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2112: String listRedirectLocation= httpClient.getRedirectLocation( lint = https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2129 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2129: ...
10 years ago (2014-03-08 01:31:56 UTC) #3
ejona
https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2579 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2579: return conn.getHeaderField("Location"); On 2014/03/08 01:31:56, pjo wrote: > do ...
10 years ago (2014-03-08 01:34:33 UTC) #4
Tanmay Vartak
10 years ago (2014-03-10 18:42:10 UTC) #5
pjo
Thank you. https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (right): https://codereview.appspot.com/72720043/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java#newcode2097 src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2097: String listBase = parts[0]; in future please ...
10 years ago (2014-03-11 00:48:35 UTC) #6
ejona
10 years ago (2014-03-11 20:20:03 UTC) #7
LGTM.

PJ gave LGTM in email thread without codereview CC'ed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b