Issue 7271047: Support apache2 frontend

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7271047: Support apache2 frontend

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by abentley-home

Modified:
11 years, 3 months ago

Reviewers:
rharding, mp+146490

Visibility:
Public.

Description

Support apache2 frontend Allow apache2 to be used as a reverse proxy by supporting the reverseproxy relation. Add config script and update docs for setting up apache2 properly. https://code.launchpad.net/~abentley/charms/precise/charmworld/apache2/+merge/146490 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -2 lines)			Patch
M	README.md	View	1 chunk	+9 lines, -1 line	1 comment	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	hooks/reverseproxy-relation-joined	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	metadata.yaml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
A	scripts/configure-apache2	View	1 chunk	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rharding

lgtm with a couple of questions. I figure this will probably need some testing/etc to ...

11 years, 3 months ago (2013-02-04 19:28:12 UTC) #2

abentley-home

11 years, 3 months ago (2013-02-04 19:46:35 UTC) #3

On 2013/02/04 19:28:12, rharding wrote:
> lgtm with a couple of questions. I figure this will probably need some
> testing/etc to get it working 100% right.
> 
> https://codereview.appspot.com/7271047/diff/1/README.md
> File README.md (right):
> 
> https://codereview.appspot.com/7271047/diff/1/README.md#newcode29
> README.md:29: juju deploy local:apache2
> Doesn't this need to point to a path with the right stucture? Should that be
> documented?

The comment above was meant to show that, but I can spell it out.


> Or is it picked up without the --repository as long as it's in the cwd?

No, it's not.

> 
> https://codereview.appspot.com/7271047/diff/1/scripts/configure-apache2
> File scripts/configure-apache2 (right):
> 
>
https://codereview.appspot.com/7271047/diff/1/scripts/configure-apache2#newcode6
> scripts/configure-apache2:6: ServerName http://staging.jujucharms.com
> This hard coding of a server name seems like trouble. I wonder if this can be
> removed

Yes, I've removed it and it still works.

Aaron

Expand All Messages | Collapse All Messages