Issue 7271046: code review 7271046: cmd/gc: clean up string index errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7271046: code review 7271046: cmd/gc: clean up string index errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: clean up string index errors Unify with array/slice errors, which were already good. Fixes issue 4232.

Patch Set 1 #

Patch Set 2 : diff -r 3c646c4b3299 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3c646c4b3299 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -18 lines)			Patch
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+19 lines, -15 lines	0 comments	Download
M	test/fixedbugs/bug205.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
A	test/fixedbugs/issue4232.go	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-02-03 07:01:03 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=3a9a5d2901f7 *** cmd/gc: clean up string index errors Unify with array/slice errors, ...

12 years, 1 month ago (2013-02-03 07:01:10 UTC) #2

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages