code review 7260043: cmd/vet: add missing -all logic

cmd/vet: add missing -all logic

[rsc, 2013-01-31 22:09:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[cookieo9, 2013-01-31 22:11:00]

On 2013/01/31 22:09:36, rsc wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

LGTM

[bradfitz, 2013-01-31 22:30:52]

LGTM

On Thu, Jan 31, 2013 at 2:09 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/vet: add missing -all logic
>
> Please review this at
https://codereview.appspot.**com/7260043/<https://codereview.appspot.com/7260...
>
> Affected files:
>   M src/cmd/vet/main.go
>
>
> Index: src/cmd/vet/main.go
> ==============================**==============================**=======
> --- a/src/cmd/vet/main.go
> +++ b/src/cmd/vet/main.go
> @@ -25,7 +25,8 @@
>  var verbose = flag.Bool("v", false, "verbose")
>  var exitCode = 0
>
> -// Flags to control which checks to perform
> +// Flags to control which checks to perform.
> +// NOTE: Add new flags to the if statement at the top of func main too.
>  var (
>         vetAll             = flag.Bool("all", true, "check everything;
> disabled if any explicit check is requested")
>         vetAtomic          = flag.Bool("atomic", false, "check for common
> mistaken usages of the sync/atomic package")
> @@ -65,7 +66,7 @@
>         flag.Parse()
>
>         // If a check is named explicitly, turn off the 'all' flag.
> -       if *vetMethods || *vetPrintf || *vetStructTags ||
> *vetUntaggedLiteral || *vetRangeLoops {
> +       if *vetAtomic || *vetBuildTags || *vetMethods || *vetPrintf ||
> *vetStructTags || *vetRangeLoops || *vetUntaggedLiteral {
>                 *vetAll = false
>         }
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-01-31 22:37:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=3a9b191a06e1 ***

cmd/vet: add missing -all logic

R=golang-dev, cookieo9, bradfitz
CC=golang-dev
https://codereview.appspot.com/7260043