code review 7249045: encoding/base64: fix test for ReadFull change

encoding/base64: fix test for ReadFull change

[rsc, 2013-01-31 22:34:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-01-31 22:44:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=8cbc63724b26 ***

encoding/base64: fix test for ReadFull change

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/7249045

[bradfitz, 2013-01-31 22:47:35]

I looked at this test code, ioutil.ReadAll, bytes.ReadFrom, and I'm not
seeing why this was required.  What was happening?

On Thu, Jan 31, 2013 at 2:44 PM, <rsc@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=8cbc63724b26<https://code.goog...
>
>
> encoding/base64: fix test for ReadFull change
>
> R=golang-dev
> CC=golang-dev
>
https://codereview.appspot.**com/7249045<https://codereview.appspot.com/7249045>
>
>
>
https://codereview.appspot.**com/7249045/<https://codereview.appspot.com/7249...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-01-31 22:52:14]

ReadAll is reading from the base64.decoder Read method. That method calls
ReadAtLeast to read from the faultInjectorReader. The one actual side
effect of the ReadAtLeast/ReadFull change is that a read that returns
enough data+error will have the error discarded, on the assumption that a
future read will get the same error. The faultInjectorReader's Reads are
satisfied by responses sent on the nextc channel. It needed a 0, err
response for that additional Read.

Russ

[bradfitz, 2013-01-31 23:07:44]

LGTM

Ah, I didn't read the Decoder.Read... I jumped right to reading
the faultInjectorReader's Read.  Makes sense.

On Thu, Jan 31, 2013 at 2:52 PM, Russ Cox <rsc@golang.org> wrote:

> ReadAll is reading from the base64.decoder Read method. That method calls
> ReadAtLeast to read from the faultInjectorReader. The one actual side
> effect of the ReadAtLeast/ReadFull change is that a read that returns
> enough data+error will have the error discarded, on the assumption that a
> future read will get the same error. The faultInjectorReader's Reads are
> satisfied by responses sent on the nextc channel. It needed a 0, err
> response for that additional Read.
>
> Russ
>
>