Issue 7248048: code review 7248048: runtime/linkers: Support PIC code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7248048: code review 7248048: runtime/linkers: Support PIC code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by elias.naur

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

runtime/linkers: Support PIC code Change the stack unwinding code to compensate for the dynamic relocation of symbols. Change the gc instruction GC_CALL to use a relative offset instead of an absolute address.

Patch Set 1 #

Patch Set 2 : diff -r b3af92ac5a0c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b3af92ac5a0c https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	src/cmd/ld/data.c	View	1	3 chunks	+1 line, -3 lines	0 comments	Download
M	src/pkg/runtime/mgc0.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/symtab.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

elias.naur

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-01-31 18:28:57 UTC) #1

rsc

11 years, 3 months ago (2013-02-01 19:25:36 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=885321ad3873 ***

runtime, cmd/ld: make code more position-independent

Change the stack unwinding code to compensate for the dynamic
relocation of symbols.
Change the gc instruction GC_CALL to use a relative offset instead of
an absolute address.

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/7248048

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages