Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 72450045: code review 72450045: cmd/ld: give acid a fighting chance at unwinding the stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by ality
Modified:
11 years, 3 months ago
Reviewers:
aram2, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/ld: give acid a fighting chance at unwinding the stack Acid can't produce a stack trace without .frame symbols. Of course, it can only unwind through linear stacks but this is still better than nothing. (I wrote an acid func to do the full unwind a long time ago but lost it and haven't worked up the courage to write it again). Note that these will only be present in the native symbol table for Plan 9 binaries.

Patch Set 1 #

Patch Set 2 : diff -r 72b4b258b09b https://code.google.com/p/go #

Patch Set 3 : diff -r 72b4b258b09b https://code.google.com/p/go #

Patch Set 4 : diff -r 17d15bc23bce https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/cmd/ld/lib.c View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ality
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-03-07 16:43:40 UTC) #1
rsc
LGTM
11 years, 3 months ago (2014-03-07 17:29:26 UTC) #2
ality
*** Submitted as https://code.google.com/p/go/source/detail?r=de89d05d7ca7 *** cmd/ld: give acid a fighting chance at unwinding the stack ...
11 years, 3 months ago (2014-03-13 01:10:56 UTC) #3
aram2
11 years, 3 months ago (2014-03-13 03:34:13 UTC) #4
Thank you.

-- 
Aram Hăvărneanu
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b