Issue 7241051: code review 7241051: cmg/gc: Fix evaluation order of map indexing during mul...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7241051: code review 7241051: cmg/gc: Fix evaluation order of map indexing during mul... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by DMorsing

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmg/gc: Fix evaluation order of map indexing during multiple assignments Fixes issue 4620.

Patch Set 1 #

Patch Set 2 : diff -r b90cad8349e0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 85014abe1574 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f9987258f37a https://code.google.com/p/go/ #

Patch Set 5 : diff -r f9987258f37a https://code.google.com/p/go/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -3 lines)			Patch
	M	src/cmd/gc/walk.c	View	1 2 3	4 chunks	+15 lines, -3 lines	0 comments	Download
	A	test/fixedbugs/issue4620.go	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 5 months ago (2013-01-30 20:31:51 UTC) #1

DMorsing

12 years, 5 months ago (2013-02-02 11:39:12 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=036190b86798 ***

cmg/gc: Fix evaluation order of map indexing during multiple assignments

Fixes issue 4620.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7241051

Expand All Messages | Collapse All Messages