Issue 7241050: syscall: use RawSyscall for sockets in nonblocking mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7241050: syscall: use RawSyscall for sockets in nonblocking mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by iant

Modified:
11 years, 1 month ago

Reviewers:
songofacandy

Visibility:
Public.

Description

syscall: use RawSyscall for sockets in nonblocking mode

Patch Set 2 : diff -r 229081515358 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 58e1987657d6 https://code.google.com/p/go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -11 lines)			Patch
M	src/pkg/syscall/exec_unix.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_bsd.go	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_darwin.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	1 2	8 chunks	+26 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_386.go	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_amd64.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_arm.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_netbsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_openbsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_unix.go	View	1	4 chunks	+23 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View	1	3 chunks	+35 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View	1	5 chunks	+57 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View	1	5 chunks	+57 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

songofacandy

Accept4 can set SOCK_NONBLOCK and SOCK_CLOEXEC atomically. https://codereview.appspot.com/7241050/diff/2001/src/pkg/syscall/syscall_linux.go File src/pkg/syscall/syscall_linux.go (right): https://codereview.appspot.com/7241050/diff/2001/src/pkg/syscall/syscall_linux.go#newcode450 src/pkg/syscall/syscall_linux.go:450: return if ...

11 years, 2 months ago (2013-01-31 11:41:33 UTC) #1

iant

Good point. Thanks. Also added the new socket to the sockets map. https://codereview.appspot.com/7241050/diff/2001/src/pkg/syscall/syscall_linux.go File src/pkg/syscall/syscall_linux.go ...

11 years, 2 months ago (2013-01-31 16:58:43 UTC) #2

*** Abandoned ***

Expand All Messages | Collapse All Messages