code review 7240043: test: add test case miscompiled by gccgo

test: add test case miscompiled by gccgo

[iant, 2013-01-28 22:52:49]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-01-28 22:55:28]

I thought the new naming convention for these files was issue*.go,
corresponding to an open issue, to avoid naming conflicts.

On Mon, Jan 28, 2013 at 2:52 PM, <iant@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: add test case miscompiled by gccgo
>
> Please review this at
https://codereview.appspot.**com/7240043/<https://codereview.appspot.com/7240...
>
> Affected files:
>   A test/fixedbugs/bug473.go
>
>
> Index: test/fixedbugs/bug473.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug473.go
> @@ -0,0 +1,69 @@
> +// run
> +
> +// Copyright 2013 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +// Used to be miscompiled by gccgo, due to a bug in handling
> +// initialization ordering.
> +
> +package main
> +
> +func F(a ...interface{}) interface{} {
> +       s := 0
> +       for _, v := range a {
> +               s += v.(int)
> +       }
> +       return s
> +}
> +
> +var V1 = F(V10, V4, V3, V11)
> +
> +var V2 = F(V1)
> +
> +var V3 = F(1)
> +
> +var V4 = F(2)
> +
> +var V5 = F(3)
> +
> +var V6 = F(4)
> +
> +var V7 = F(5)
> +
> +var V8 = F(V14, V7, V3, V6, V5)
> +
> +var V9 = F(V4, F(V12))
> +
> +var V10 = F(V4, V9)
> +
> +var V11 = F(6)
> +
> +var V12 = F(V5, V3, V8)
> +
> +var V13 = F(7)
> +
> +var V14 = F(8)
> +
> +func expect(name string, a interface{}, b int) {
> +       if a.(int) != b {
> +               panic(name)
> +       }
> +}
> +
> +func main() {
> +       expect("V1", V1, 38)
> +       expect("V2", V2, 38)
> +       expect("V3", V3, 1)
> +       expect("V4", V4, 2)
> +       expect("V5", V5, 3)
> +       expect("V6", V6, 4)
> +       expect("V7", V7, 5)
> +       expect("V8", V8, 21)
> +       expect("V9", V9, 27)
> +       expect("V10", V10, 29)
> +       expect("V11", V11, 6)
> +       expect("V12", V12, 25)
> +       expect("V13", V13, 7)
> +       expect("V14", V14, 8)
> +}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group, send email to golang-dev+unsubscribe@**
> googlegroups.com <golang-dev%2Bunsubscribe@googlegroups.com>.
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-01-28 23:26:49]

LGTM

Yes, everyone else is avoiding conflicts with me and Ian. :-)

[bradfitz, 2013-01-28 23:30:02]

On Mon, Jan 28, 2013 at 3:26 PM, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
> Yes, everyone else is avoiding conflicts with me and Ian. :-)
>

Hey, conflicts have happened before... that's what started the conversation
before to switch to issueNNNN.  I see 29 unique committers in that
directory.

But yeah, I don't really care.

[iant2, 2013-01-29 00:16:38]

On Mon, Jan 28, 2013 at 2:55 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> I thought the new naming convention for these files was issue*.go,
> corresponding to an open issue, to avoid naming conflicts.

I'm following that approach when there is an open issue, but there is
no issue for this.  I don't think it's wrong to use both approaches.
I don't think it's necessary to open an issue just to create a test
case.

Ian

> On Mon, Jan 28, 2013 at 2:52 PM, <iant@golang.org> wrote:
>>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> test: add test case miscompiled by gccgo
>>
>> Please review this at https://codereview.appspot.com/7240043/
>>
>> Affected files:
>>   A test/fixedbugs/bug473.go
>>
>>
>> Index: test/fixedbugs/bug473.go
>> ===================================================================
>> new file mode 100644
>> --- /dev/null
>> +++ b/test/fixedbugs/bug473.go
>> @@ -0,0 +1,69 @@
>> +// run
>> +
>> +// Copyright 2013 The Go Authors.  All rights reserved.
>> +// Use of this source code is governed by a BSD-style
>> +// license that can be found in the LICENSE file.
>> +
>> +// Used to be miscompiled by gccgo, due to a bug in handling
>> +// initialization ordering.
>> +
>> +package main
>> +
>> +func F(a ...interface{}) interface{} {
>> +       s := 0
>> +       for _, v := range a {
>> +               s += v.(int)
>> +       }
>> +       return s
>> +}
>> +
>> +var V1 = F(V10, V4, V3, V11)
>> +
>> +var V2 = F(V1)
>> +
>> +var V3 = F(1)
>> +
>> +var V4 = F(2)
>> +
>> +var V5 = F(3)
>> +
>> +var V6 = F(4)
>> +
>> +var V7 = F(5)
>> +
>> +var V8 = F(V14, V7, V3, V6, V5)
>> +
>> +var V9 = F(V4, F(V12))
>> +
>> +var V10 = F(V4, V9)
>> +
>> +var V11 = F(6)
>> +
>> +var V12 = F(V5, V3, V8)
>> +
>> +var V13 = F(7)
>> +
>> +var V14 = F(8)
>> +
>> +func expect(name string, a interface{}, b int) {
>> +       if a.(int) != b {
>> +               panic(name)
>> +       }
>> +}
>> +
>> +func main() {
>> +       expect("V1", V1, 38)
>> +       expect("V2", V2, 38)
>> +       expect("V3", V3, 1)
>> +       expect("V4", V4, 2)
>> +       expect("V5", V5, 3)
>> +       expect("V6", V6, 4)
>> +       expect("V7", V7, 5)
>> +       expect("V8", V8, 21)
>> +       expect("V9", V9, 27)
>> +       expect("V10", V10, 29)
>> +       expect("V11", V11, 6)
>> +       expect("V12", V12, 25)
>> +       expect("V13", V13, 7)
>> +       expect("V14", V14, 8)
>> +}
>>
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group, send email to
>> golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>

[iant, 2013-01-29 00:17:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=c3155f9f1bb6 ***

test: add test case miscompiled by gccgo

R=golang-dev, bradfitz, rsc, iant
CC=golang-dev
https://codereview.appspot.com/7240043