code review 7239044: bytes, strings: add TrimPrefix and TrimSuffix

bytes, strings: add TrimPrefix and TrimSuffix

Everybody either gets confused and thinks this is
TrimLeft/TrimRight or does this by hand which gets
repetitive looking.

[bradfitz, 2013-01-30 19:25:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-01-30 19:50:07]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-01-30 20:33:48]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-01-30 20:35:17]

Please add examples.

[bradfitz, 2013-01-30 20:58:33]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-01-30 21:17:57]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-01-30 21:18:53]

Now with examples and all the callers I could easily find fixed up.


On Wed, Jan 30, 2013 at 1:17 PM, <bradfitz@golang.org> wrote:

> Hello rsc@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/7239044/<https://codereview.appspot.com/7239...
>

[dsymonds, 2013-01-30 21:54:55]

OMG my hero. the number of times I've written that code...

[kevlar, 2013-01-30 21:55:01]

LGTM

Awesome :)

https://codereview.appspot.com/7239044/diff/11002/src/pkg/strings/example_tes...
File src/pkg/strings/example_test.go (right):

https://codereview.appspot.com/7239044/diff/11002/src/pkg/strings/example_tes...
src/pkg/strings/example_test.go:183: func ExampleTrimSuffix() {
I would include an example where the result is compared to the input (i.e. to
tell if the stripping took place), because it might be worth pointing out that
the check is cheap in the trim-did-happen case, because the lengths will differ.

[bradfitz, 2013-02-01 16:41:32]

*** Submitted as https://code.google.com/p/go/source/detail?r=c7353c98694b ***

bytes, strings: add TrimPrefix and TrimSuffix

Everybody either gets confused and thinks this is
TrimLeft/TrimRight or does this by hand which gets
repetitive looking.

R=rsc, kevlar
CC=golang-dev
https://codereview.appspot.com/7239044