Issue 7237047: code review 7237047: exp/ssa: fix breakage due to https://code.google.com/p/...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7237047: code review 7237047: exp/ssa: fix breakage due to https://code.google.com/p/... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by adonovan

Modified:
12 years, 5 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

exp/ssa: fix breakage due to https://code.google.com/p/go/source/detail?r=ca5e5de48173 I don't understand why this didn't show up during my testing.

Patch Set 2 : diff -r 996e3e9e4787 https://adonovan%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 996e3e9e4787 https://adonovan%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 996e3e9e4787 https://adonovan%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r c3155f9f1bb6 https://adonovan%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r c3155f9f1bb6 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r c3155f9f1bb6 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r c3155f9f1bb6 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	src/pkg/exp/ssa/func.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello bradfitz, bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://adonovan%40google.com@code.google.com/p/go/

12 years, 5 months ago (2013-01-29 00:11:32 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/7237047/diff/4001/src/pkg/exp/ssa/func.go File src/pkg/exp/ssa/func.go (right): https://codereview.appspot.com/7237047/diff/4001/src/pkg/exp/ssa/func.go#newcode13 src/pkg/exp/ssa/func.go:13: // Mode bits for additional diagnostics and checking. ...

12 years, 5 months ago (2013-01-29 00:13:13 UTC) #2

adonovan

12 years, 5 months ago (2013-01-29 00:21:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=921e53d4863c ***

exp/ssa: fix breakage due to
https://code.google.com/p/go/source/detail?r=ca5e5de48173

I don't understand why this didn't show up during my testing.

R=bradfitz
TBR=bradfitz
CC=golang-dev
https://codereview.appspot.com/7237047

Expand All Messages | Collapse All Messages