Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 7237043: Serialized unit execution on a machine/container

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by hazmat
Modified:
9 years, 6 months ago
Reviewers:
mp+145101
Visibility:
Public.

Description

Serialized unit execution on a machine/container To prevent races for system resources like apt between different units running on the same machine/container a shared file lock is taken out for hook execution. Mechanism is resistant to dead processes holding lock, however per previous juju behavior no timeout is provided for maximum hook execution time. https://code.launchpad.net/~hazmat/juju/serialized-hook-exec/+merge/145101 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Serialized unit execution on a machine/container #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/hooks/executor.py View 1 4 chunks +21 lines, -3 lines 0 comments Download
M juju/hooks/tests/test_executor.py View 1 3 chunks +53 lines, -1 line 0 comments Download

Messages

Total messages: 4
hazmat
Please take a look.
9 years, 6 months ago (2013-01-27 23:09:02 UTC) #1
jimbaker
+1, with the minors fixed. https://codereview.appspot.com/7237043/diff/1/juju/hooks/executor.py File juju/hooks/executor.py (right): https://codereview.appspot.com/7237043/diff/1/juju/hooks/executor.py#newcode137 juju/hooks/executor.py:137: self._fs_lock.unlock() Shouldn't this unlock ...
9 years, 6 months ago (2013-01-31 00:39:21 UTC) #2
hazmat
thanks for the review. https://codereview.appspot.com/7237043/diff/1/juju/hooks/executor.py File juju/hooks/executor.py (right): https://codereview.appspot.com/7237043/diff/1/juju/hooks/executor.py#newcode137 juju/hooks/executor.py:137: self._fs_lock.unlock() On 2013/01/31 00:39:21, jimbaker ...
9 years, 6 months ago (2013-01-31 01:43:47 UTC) #3
hazmat
9 years, 6 months ago (2013-01-31 14:39:33 UTC) #4
*** Submitted:

Serialized unit execution on a machine/container

To prevent races for system resources like apt between different
units running on the same machine/container a shared file lock is
taken out for hook execution. Mechanism is resistant to dead 
processes holding lock, however per previous juju behavior no 
timeout is provided for maximum hook execution time.

R=jimbaker
CC=
https://codereview.appspot.com/7237043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b