Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 7235078: Node

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by ideasman42
Modified:
9 years, 3 months ago
Reviewers:
bartekskorupa, bf-codereview
CC:
bartekskorupa_bartekskorupa.com
Base URL:
https://svn.blender.org/svnroot/bf-extensions/trunk/py/scripts/addons/
Visibility:
Public.

Description

Node

Patch Set 1 #

Total comments: 17
Unified diffs Side-by-side diffs Delta from patch set Stats (+1326 lines, -0 lines) Patch
A node_efficiency_tools.py View 1 chunk +1326 lines, -0 lines 17 comments Download

Messages

Total messages: 5
ideasman42
9 years, 3 months ago (2013-02-01 13:35:59 UTC) #1
ideasman42
Generally fine to merge but suggest changes, - Unless theres a reason to use lists, ...
9 years, 3 months ago (2013-02-01 13:55:11 UTC) #2
bartekskorupa
I'll try to address most of the issues, but I have problems with one of ...
9 years, 3 months ago (2013-02-01 14:27:10 UTC) #3
bartekskorupa
Most of issues have been addressed. Only 2 left because I have doubts I'll need ...
9 years, 3 months ago (2013-02-01 18:40:36 UTC) #4
bartekskorupa
9 years, 3 months ago (2013-02-02 12:52:21 UTC) #5
Kemap items handling corrected. It didn't at first work because of my mistakes.

https://codereview.appspot.com/7235078/diff/1/node_efficiency_tools.py
File node_efficiency_tools.py (right):

https://codereview.appspot.com/7235078/diff/1/node_efficiency_tools.py#newcod...
node_efficiency_tools.py:1289: def unregister():
On 2013/02/01 13:55:11, ideasman42 wrote:
> Suggest to use this method of removing keymaps. more direct.
> 
>
http://www.blender.org/documentation/blender_python_api_2_65_9/info_tutorial_...

Done.

In my previous tests I must have made some mistakes, so I wrongly assumed that
there must be some issue with your solution. I analyzed everything and now I
have no doubts whatsoever that your way is THE way :-). Sorry for that. I have
modified my script according to suggestions
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b