Issue 7235058: trivial: better nova comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7235058: trivial: better nova comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dimitern

Modified:
11 years, 2 months ago

Reviewers:
mp+145434

Visibility:
Public.

Description

trivial: better nova comments Follow-up on https://codereview.appspot.com/7228058/, adding better comments on the Nova ServerDetail struct's fields. https://code.launchpad.net/~dimitern/goose/nova-addresses3/+merge/145434 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : trivial: better nova comments #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -15 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	nova/nova.go	View	1	1 chunk	+29 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/7235058/diff/1/nova/nova.go File nova/nova.go (right): https://codereview.appspot.com/7235058/diff/1/nova/nova.go#newcode159 nova/nova.go:159: // address of the server, or "" if ...

11 years, 2 months ago (2013-01-29 16:31:51 UTC) #2

dimitern

11 years, 2 months ago (2013-01-29 16:33:21 UTC) #3

*** Submitted:

trivial: better nova comments

Follow-up on https://codereview.appspot.com/7228058/, adding better
comments on the Nova ServerDetail struct's fields.

R=rog
CC=
https://codereview.appspot.com/7235058

Expand All Messages | Collapse All Messages