Issue 7235044: code review 7235044: doc/go_spec: more examples for unspecified cases of the...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7235044: code review 7235044: doc/go_spec: more examples for unspecified cases of the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by minux1

Modified:
12 years, 6 months ago

Reviewers:
gri, iant

CC:
golang-dev, bradfitz, gri, iant, rsc

Visibility:
Public.

Description

doc/go_spec: more examples for unspecified cases of the evaluation order

Patch Set 2 : diff -r 3a153f3d2680 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a153f3d2680 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a44171137af8 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 6c6b3968b605 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 7 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Total comments: 1

Patch Set 8 : diff -r 578baa4acf63 https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	doc/go_spec.html	View	1 2 3 4 5 6 7	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, bradfitz@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 6 months ago (2013-06-07 09:34:45 UTC) #2

gri

LGTM. But please fix the date before submitting. https://codereview.appspot.com/7235044/diff/19001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/7235044/diff/19001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": ...

12 years, 6 months ago (2013-06-10 16:31:54 UTC) #4

minux1

12 years, 6 months ago (2013-06-10 18:52:17 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3361afb4f8de ***

doc/go_spec: more examples for unspecified cases of the evaluation order

R=golang-dev, bradfitz, gri, iant, rsc
CC=golang-dev
https://codereview.appspot.com/7235044

Expand All Messages | Collapse All Messages