Issue 7233046: Make builddb compile and install again

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7233046: Make builddb compile and install again

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by gz

Modified:
11 years, 3 months ago

Reviewers:
mp+145166, jameinel, TheMue

Visibility:
Public.

Description

Make builddb compile and install again The AddService call needs to be conn.State.AddService not on conn directly. https://code.launchpad.net/~gz/juju-core/builddb_install_error/+merge/145166 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make builddb compile and install again #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/builddb/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jameinel

LGTM, this is certainly why the goose 'test.py' does 'go build' before 'go test'.

11 years, 3 months ago (2013-01-28 12:21:58 UTC) #2

11 years, 3 months ago (2013-01-28 12:45:01 UTC) #4

*** Submitted:

Make builddb compile and install again

The AddService call needs to be conn.State.AddService not on conn directly.

R=jameinel, TheMue
CC=
https://codereview.appspot.com/7233046

Expand All Messages | Collapse All Messages