Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 7231079: Increase zk session and ping times.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by hazmat
Modified:
9 years, 6 months ago
Reviewers:
mp+146169, bcsaller
Visibility:
Public.

Description

Increase zk session and ping times. During scale testing work, one of the take aways was the default zookeeper session time was too low, which caused issues for any transient communication problems between the agents the zk. The managed client work landed subsequently does recovery for this and for session expiration, but its better to avoid the issue entirely by increasing the session time and increasing the heartbeat time periodicity. https://code.launchpad.net/~hazmat/juju/increase-session-timeout/+merge/146169 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : Increase zk session and ping times. #

Patch Set 3 : Increase zk session and ping times. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -164 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/agents/base.py View 2 chunks +3 lines, -1 line 0 comments Download
M juju/environment/config.py View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M juju/environment/tests/test_config.py View 1 2 2 chunks +0 lines, -61 lines 0 comments Download
A juju/lib/port.py View 1 chunk +13 lines, -0 lines 0 comments Download
A juju/lib/tests/test_port.py View 1 chunk +32 lines, -0 lines 0 comments Download
M juju/lib/tests/test_zk.py View 3 chunks +14 lines, -8 lines 0 comments Download
M juju/lib/zk.py View 1 5 chunks +17 lines, -4 lines 0 comments Download
M juju/providers/common/cloudinit.py View 1 3 chunks +19 lines, -11 lines 0 comments Download
M juju/providers/common/connect.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M juju/providers/common/tests/data/cloud_init_bootstrap View 3 chunks +5 lines, -4 lines 0 comments Download
M juju/providers/common/tests/data/cloud_init_bootstrap_testing View 1 chunk +3 lines, -1 line 0 comments Download
M juju/providers/common/tests/data/cloud_init_bootstrap_zookeepers View 3 chunks +5 lines, -4 lines 0 comments Download
M juju/providers/ec2/tests/data/bootstrap_cloud_init View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M juju/providers/ec2/tests/test_bootstrap.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M juju/providers/local/__init__.py View 2 chunks +1 line, -1 line 0 comments Download
M juju/providers/local/tests/test_files.py View 2 chunks +2 lines, -3 lines 0 comments Download
M juju/state/sshclient.py View 1 chunk +4 lines, -1 line 0 comments Download
M juju/state/tests/test_utils.py View 2 chunks +1 line, -30 lines 0 comments Download
M juju/state/utils.py View 1 chunk +0 lines, -12 lines 0 comments Download
M test View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6
hazmat
Please take a look.
9 years, 6 months ago (2013-02-01 17:01:26 UTC) #1
bcsaller
LGTM, some minors below but they are optional. https://codereview.appspot.com/7231079/diff/1/juju/lib/port.py File juju/lib/port.py (right): https://codereview.appspot.com/7231079/diff/1/juju/lib/port.py#newcode5 juju/lib/port.py:5: """Get ...
9 years, 6 months ago (2013-02-01 17:12:19 UTC) #2
hazmat
thanks for the review. https://codereview.appspot.com/7231079/diff/1/juju/lib/port.py File juju/lib/port.py (right): https://codereview.appspot.com/7231079/diff/1/juju/lib/port.py#newcode5 juju/lib/port.py:5: """Get an open port on ...
9 years, 6 months ago (2013-02-01 17:50:14 UTC) #3
hazmat
Please take a look.
9 years, 6 months ago (2013-02-01 17:50:53 UTC) #4
bcsaller
Thanks for the changes, LGTM
9 years, 6 months ago (2013-02-01 17:53:14 UTC) #5
hazmat
9 years, 6 months ago (2013-02-01 18:52:20 UTC) #6
*** Submitted:

Increase zk session and ping times.

During scale testing work, one of the take aways was the default zookeeper 
session time was too low, which caused issues for any transient communication
problems between the agents the zk. The managed client work landed subsequently 
does recovery for this and for session expiration, but its better to avoid
the issue entirely by increasing the session time and increasing the heartbeat
time periodicity.

R=bcsaller
CC=
https://codereview.appspot.com/7231079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b