Add a little bit to release QA.

Add a little bit to release QA.



https://code.launchpad.net/~benji/juju-gui/slight-improvement-to-release-QA/+merge/146151

(do not edit description out of merge proposal)

[benji, 2013-02-01 16:05:38]

Please take a look.

[benji, 2013-02-01 16:14:16]

Please take a look.

[benji, 2013-02-01 16:47:05]

Please take a look.

[teknico, 2013-02-01 17:16:36]

Request re-review.

I'm afraid there are some more changes to make. :-)

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode170
docs/process.rst:170: improv.py script.
Running the Python web server is covered by the "NO_BZR=1 make prod" command at
the line 165, right above. The mention of running improv is a good idea, maybe
also adding "...as described in the HACKING file".

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode175
docs/process.rst:175: - We want a real QA script for the future.
You want to reflect this whole change in the developer checklist below.

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode221
docs/process.rst:221: ``cmp`` command).
Same goes for adding this bit to the download checklist too.

[benji, 2013-02-01 17:26:43]

Please take a look.

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode170
docs/process.rst:170: improv.py script.
On 2013/02/01 17:16:37, teknico wrote:
> Running the Python web server is covered by the "NO_BZR=1 make prod" command
at
> the line 165, right above. The mention of running improv is a good idea, maybe
> also adding "...as described in the HACKING file".

Done.

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode175
docs/process.rst:175: - We want a real QA script for the future.
On 2013/02/01 17:16:37, teknico wrote:
> You want to reflect this whole change in the developer checklist below.

Done.

https://codereview.appspot.com/7231077/diff/7001/docs/process.rst#newcode221
docs/process.rst:221: ``cmp`` command).
On 2013/02/01 17:16:37, teknico wrote:
> Same goes for adding this bit to the download checklist too.

Done.

[benji, 2013-02-01 17:26:59]

I have incorporated all of your good suggestions -- which is all of them in this
case ;)

[teknico, 2013-02-01 17:31:13]

Land with changes.

Don't despair, we're almost there! :-)

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst#newcode168
docs/process.rst:168: - In Chrome and Firefox, QA the application.
This flows much better than what I had, I didn't like it. Thanks! Just one
thing, maybe add double ticks around "improv.py"? :-)

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst#newcode253
docs/process.rst:253: - Start the improv.py script as described in the HACKING
file.
Ditto.

[benji, 2013-02-01 17:35:02]

Double ticks added.  Landing.

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst#newcode168
docs/process.rst:168: - In Chrome and Firefox, QA the application.
On 2013/02/01 17:31:13, teknico wrote:
> This flows much better than what I had, I didn't like it. Thanks! Just one
> thing, maybe add double ticks around "improv.py"? :-)

You must own double tick futures. ;)  Added.

https://codereview.appspot.com/7231077/diff/10001/docs/process.rst#newcode253
docs/process.rst:253: - Start the improv.py script as described in the HACKING
file.
On 2013/02/01 17:31:13, teknico wrote:
> Ditto.

Done.

[benji, 2013-02-01 17:35:28]

Please take a look.

[benji, 2013-02-01 17:37:55]

*** Submitted:

Add a little bit to release QA.

R=teknico
CC=
https://codereview.appspot.com/7231077