code review 7231055: misc/emacs: Present "godoc" documentation buffers using...

misc/emacs: Present "godoc" documentation buffers using view-mode.

Mimic the Emacs convention of presenting read-only files meant
for browsing using view-mode, rather than Fundamental mode
which mistakenly allows editing of the "godoc" content.
Fixes issue 4322.

[seharris, 2013-01-29 19:46:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/go

[bradfitz, 2013-02-19 18:53:47]

LGTM but I'm just an (GNU-)Emacs user.

You'll need to complete a CLA as described at
http://golang.org/doc/contribute.html#copyright

On Tue, Jan 29, 2013 at 11:46 AM, <seharris@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/**go <https://go.googlecode.com/hg/go>
>
>
> Description:
> misc/emacs: Present "godoc" documentation buffers using view-mode.
>
> Mimic the Emacs convention of presenting read-only files meant
> for browsing using view-mode, rather than Fundamental mode
> which mistakenly allows editing of the "godoc" content.
> Fixes issue 4322.
>
> Please review this at
https://codereview.appspot.**com/7231055/<https://codereview.appspot.com/7231...
>
> Affected files:
>   M misc/emacs/go-mode.el
>
>
> Index: misc/emacs/go-mode.el
> ==============================**==============================**=======
> --- a/misc/emacs/go-mode.el
> +++ b/misc/emacs/go-mode.el
> @@ -875,7 +875,7 @@
>    (with-current-buffer (process-buffer proc)
>      (cond ((string= event "finished\n")  ;; Successful exit.
>             (goto-char (point-min))
> -           (display-buffer (current-buffer) 'not-this-window))
> +           (view-buffer (current-buffer) 'kill-buffer))
>            ((not (= (process-exit-status proc) 0))  ;; Error exit.
>             (let ((output (buffer-string)))
>               (kill-buffer (current-buffer))
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[Sameer Ajmani, 2013-02-19 21:13:01]

LGTM too.

On 2013/02/19 18:53:47, bradfitz wrote:
> LGTM but I'm just an (GNU-)Emacs user.
> 
> You'll need to complete a CLA as described at
> http://golang.org/doc/contribute.html#copyright
> 
> On Tue, Jan 29, 2013 at 11:46 AM, <mailto:seharris@gmail.com> wrote:
> 
> > Reviewers: http://golang-dev_googlegroups.com,
> >
> > Message:
> > Hello mailto:golang-dev@googlegroups.com,
> >
> > I'd like you to review this change to
> > https://go.googlecode.com/hg/**go <https://go.googlecode.com/hg/go>
> >
> >
> > Description:
> > misc/emacs: Present "godoc" documentation buffers using view-mode.
> >
> > Mimic the Emacs convention of presenting read-only files meant
> > for browsing using view-mode, rather than Fundamental mode
> > which mistakenly allows editing of the "godoc" content.
> > Fixes issue 4322.
> >
> > Please review this at
>
https://codereview.appspot.**com/7231055/%3Chttps://codereview.appspot.com/72...>
> >
> > Affected files:
> >   M misc/emacs/go-mode.el
> >
> >
> > Index: misc/emacs/go-mode.el
> > ==============================**==============================**=======
> > --- a/misc/emacs/go-mode.el
> > +++ b/misc/emacs/go-mode.el
> > @@ -875,7 +875,7 @@
> >    (with-current-buffer (process-buffer proc)
> >      (cond ((string= event "finished\n")  ;; Successful exit.
> >             (goto-char (point-min))
> > -           (display-buffer (current-buffer) 'not-this-window))
> > +           (view-buffer (current-buffer) 'kill-buffer))
> >            ((not (= (process-exit-status proc) 0))  ;; Error exit.
> >             (let ((output (buffer-string)))
> >               (kill-buffer (current-buffer))
> >
> >
> > --
> >
> > ---You received this message because you are subscribed to the Google
> > Groups "golang-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to
>
mailto:golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
> > .
> > For more options, visit
>
https://groups.google.com/**groups/opt_out%3Chttps://groups.google.com/groups...>
> > .
> >
> >
> >

[seharris, 2013-02-20 00:32:07]

On 2013/02/19 18:53:47, bradfitz wrote:

> You'll need to complete a CLA as described at
> http://golang.org/doc/contribute.html#copyright

Per your request, I agreed to and submitted the form.

[bradfitz, 2013-02-20 22:42:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=7dc8e8103052 ***

misc/emacs: Present "godoc" documentation buffers using view-mode.

Mimic the Emacs convention of presenting read-only files meant
for browsing using view-mode, rather than Fundamental mode
which mistakenly allows editing of the "godoc" content.
Fixes issue 4322.

R=golang-dev, bradfitz, sameer
CC=golang-dev
https://codereview.appspot.com/7231055

Committer: Brad Fitzpatrick <bradfitz@golang.org>