Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 7231050: code review 7231050: exp/ssa: make Parameters values, not addresses. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by adonovan
Modified:
11 years, 2 months ago
Reviewers:
CC:
iant2, iant, golang-dev
Visibility:
Public.

Description

exp/ssa: make Parameters values, not addresses. We explicitly spill all parameters to the frame during initial SSA construction. (Later passes will remove spills.) We now properly handle local Allocs escaping via Captures. Also: allocate BasicBlock.Succs inline.

Patch Set 1 #

Patch Set 2 : diff -r 040e3c08d41e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 040e3c08d41e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 040e3c08d41e https://code.google.com/p/go/ #

Patch Set 5 : diff -r ab5aaf4b34f2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -45 lines) Patch
M src/pkg/exp/ssa/blockopt.go View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/pkg/exp/ssa/func.go View 1 2 3 4 6 chunks +31 lines, -19 lines 0 comments Download
M src/pkg/exp/ssa/ssa.go View 1 2 2 chunks +9 lines, -21 lines 0 comments Download

Messages

Total messages: 3
adonovan
Hello iant@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 2 months ago (2013-01-28 23:48:54 UTC) #1
iant
LGTM
11 years, 2 months ago (2013-01-29 00:22:37 UTC) #2
adonovan
11 years, 2 months ago (2013-01-29 15:49:20 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=528c41009424 ***

exp/ssa: make Parameters values, not addresses.

We explicitly spill all parameters to the frame during initial
SSA construction.  (Later passes will remove spills.)
We now properly handle local Allocs escaping via Captures.

Also: allocate BasicBlock.Succs inline.

R=iant, iant
CC=golang-dev
https://codereview.appspot.com/7231050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b