Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(319)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 7231044: api: http issue 140: Limit use of Guava library (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by yanivi
Modified:
13 years, 8 months ago
Reviewers:
ngmiceli
CC:
rmistry, peleyal
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

api: http issue 140: Limit use of Guava library depends on: https://codereview.appspot.com/7230044/ https://codereview.appspot.com/7223046/

Patch Set 1 #

Patch Set 2 : revert src/test & update #

Patch Set 3 : ByteStreams #

Total comments: 2

Patch Set 4 : fix import in ClientLogin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/accounts/GoogleAccountManager.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAuthIOException.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java View 2 chunks +1 line, -1 line 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/JdoSubscriptionStore.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/WebHookDeliveryMethod.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeFlow.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeRequestUrl.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeTokenRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleBrowserClientRequestUrl.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecrets.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenVerifier.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchRequest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonResponseException.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonRpcHttpTransport.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/json/JsonCParser.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpDownloader.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClient.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Notification.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Subscription.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotificationCallback.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/UnparsedNotification.java View 1 chunk +2 lines, -2 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/xml/atom/AtomPatchRelativeToOriginalContent.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
yanivi
13 years, 9 months ago (2013-01-26 04:12:51 UTC) #1
yanivi
13 years, 8 months ago (2013-01-30 14:33:25 UTC) #2
yanivi
13 years, 8 months ago (2013-01-30 14:35:05 UTC) #3
yanivi
ping
13 years, 8 months ago (2013-02-04 14:17:12 UTC) #4
ngmiceli
https://codereview.appspot.com/7231044/diff/12001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java (right): https://codereview.appspot.com/7231044/diff/12001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java#newcode188 google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java:188: if (!com.google.api.client.util.Strings.isNullOrEmpty(detailString)) { Import instead?
13 years, 8 months ago (2013-02-04 22:46:07 UTC) #5
yanivi
https://codereview.appspot.com/7231044/diff/12001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java (right): https://codereview.appspot.com/7231044/diff/12001/google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java#newcode188 google-api-client/src/main/java/com/google/api/client/googleapis/auth/clientlogin/ClientLogin.java:188: if (!com.google.api.client.util.Strings.isNullOrEmpty(detailString)) { On 2013/02/04 22:46:07, ngmiceli wrote: > ...
13 years, 8 months ago (2013-02-04 23:07:03 UTC) #6
ngmiceli
13 years, 8 months ago (2013-02-04 23:35:02 UTC) #7 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b