Issue 7229072: code review 7229072: cmd/gc: clearer error for defer/go of conversion or inv...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7229072: code review 7229072: cmd/gc: clearer error for defer/go of conversion or inv... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: clearer error for defer/go of conversion or invalid function call Fixes issue 4654.

Patch Set 1 #

Patch Set 2 : diff -r 83618f3eee8e https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -35 lines)			Patch
M	src/cmd/gc/const.c	View	1	3 chunks	+23 lines, -6 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	3 chunks	+10 lines, -4 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	6 chunks	+65 lines, -3 lines	0 comments	Download
M	test/fixedbugs/issue4463.go	View	1	2 chunks	+22 lines, -22 lines	0 comments	Download
A	test/fixedbugs/issue4654.go	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-02-02 02:02:13 UTC) #1

rsc

12 years, 1 month ago (2013-02-02 02:02:19 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=e619e8e0f44a ***

cmd/gc: clearer error for defer/go of conversion or invalid function call

Fixes issue 4654.

R=ken2
CC=golang-dev
https://codereview.appspot.com/7229072

Expand All Messages | Collapse All Messages