Issue 7229071: code review 7229071: cmd/go: run examples in source order, not name order

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7229071: code review 7229071: cmd/go: run examples in source order, not name order (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rsc

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/go: run examples in source order, not name order Add Order field to doc.Example and write doc comments there. Fixes issue 4662.

Patch Set 2 : diff -r 885321ad3873 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f9987258f37a https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8faf9010cd77 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -1 line)			Patch
M	src/cmd/go/test.bash	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
A	src/cmd/go/testdata/example1_test.go	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/example2_test.go	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/pkg/go/doc/example.go	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2013-02-01 19:43:31 UTC) #1

iant

https://codereview.appspot.com/7229071/diff/2001/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/7229071/diff/2001/src/cmd/go/test.bash#newcode283 src/cmd/go/test.bash:283: ./testgo test testdata/example[12]_test.go I think you forgot to add ...

11 years, 2 months ago (2013-02-02 14:38:32 UTC) #2

rsc

Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-02-02 17:22:49 UTC) #3

rsc

11 years, 2 months ago (2013-02-02 21:26:17 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=8dfcf31fb1f8 ***

cmd/go: run examples in source order, not name order

Add Order field to doc.Example and write doc comments there.

Fixes issue 4662.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7229071

Expand All Messages | Collapse All Messages