Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 7229071: code review 7229071: cmd/go: run examples in source order, not name order (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by rsc
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, iant
Visibility:
Public.

Description

cmd/go: run examples in source order, not name order Add Order field to doc.Example and write doc comments there. Fixes issue 4662.

Patch Set 1 #

Patch Set 2 : diff -r 885321ad3873 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f9987258f37a https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8faf9010cd77 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M src/cmd/go/test.bash View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/cmd/go/test.go View 1 2 chunks +9 lines, -1 line 0 comments Download
A src/cmd/go/testdata/example1_test.go View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A src/cmd/go/testdata/example2_test.go View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M src/pkg/go/doc/example.go View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2013-02-01 19:43:31 UTC) #1
iant
https://codereview.appspot.com/7229071/diff/2001/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/7229071/diff/2001/src/cmd/go/test.bash#newcode283 src/cmd/go/test.bash:283: ./testgo test testdata/example[12]_test.go I think you forgot to add ...
9 years, 6 months ago (2013-02-02 14:38:32 UTC) #2
rsc
Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2013-02-02 17:22:49 UTC) #3
iant
LGTM
9 years, 6 months ago (2013-02-02 18:17:37 UTC) #4
rsc
9 years, 6 months ago (2013-02-02 21:26:17 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=8dfcf31fb1f8 ***

cmd/go: run examples in source order, not name order

Add Order field to doc.Example and write doc comments there.

Fixes issue 4662.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7229071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b