Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5383)

Issue 7229060: nova: Fix RunServer userdata encoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dimitern
Modified:
11 years, 2 months ago
Reviewers:
mp+145621
Visibility:
Public.

Description

nova: Fix RunServer userdata encoding According to the go docs, []byte fields are automatically serialized as base64 encoded strings, so no need to do it twice (and post-bootstrap fails due to this). https://code.launchpad.net/~dimitern/goose/nova-runserver-base64/+merge/145621 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : nova: Fix RunServer userdata encoding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M nova/nova.go View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4
dimitern
Please take a look.
11 years, 2 months ago (2013-01-30 14:48:21 UTC) #1
gz
So, this is fine in general as an alternative to Ian's fix of using string ...
11 years, 2 months ago (2013-01-30 14:51:04 UTC) #2
dimitern
On 2013/01/30 14:51:04, gz wrote: > So, this is fine in general as an alternative ...
11 years, 2 months ago (2013-01-30 15:20:37 UTC) #3
dimitern
11 years, 2 months ago (2013-01-30 15:21:52 UTC) #4
*** Submitted:

nova: Fix RunServer userdata encoding

According to the go docs, []byte fields are automatically serialized as
base64 encoded strings, so no need to do it twice (and post-bootstrap
fails due to this).

R=gz
CC=
https://codereview.appspot.com/7229060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b