Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2632)

Issue 7228070: Remove service click actions

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by bcsaller
Modified:
5 years, 10 months ago
Reviewers:
mp+145866
Visibility:
Public.

Description

Remove service click actions This branch builds on the view model improvements to remove service click actions, simplify the calling convention of methods that lived there and remove their dependencies on the service_click_actions closure. https://code.launchpad.net/~bcsaller/juju-gui/service-click-actions-begone/+merge/145866 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove service click actions #

Total comments: 5

Patch Set 3 : Remove service click actions #

Total comments: 2

Patch Set 4 : Remove service click actions #

Patch Set 5 : Remove service click actions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+932 lines, -485 lines) Patch
M .bzrignore View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGES.yaml View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M Makefile View 1 2 3 4 7 chunks +32 lines, -4 lines 0 comments Download
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M app/views/topology/service.js View 1 2 3 19 chunks +209 lines, -237 lines 0 comments Download
M app/views/topology/topology.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M app/views/utils.js View 1 2 6 chunks +17 lines, -7 lines 0 comments Download
A archives/selenium-2.29.0.tar.gz View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A bin/test-charm View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A docs/browser-testing.rst View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
M docs/index.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M docs/process.rst View 1 2 3 4 5 chunks +155 lines, -79 lines 0 comments Download
A lib/deploy_charm_for_testing.py View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
M lib/server.js View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
A test/browser.py View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
M test/test_application_notifications.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
A test/test_charm_running.py View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
A test/test_deploy_charm_for_testing.py View 1 2 3 4 1 chunk +121 lines, -0 lines 0 comments Download
M test/test_environment_view.js View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M test/test_service_module.js View 1 2 6 chunks +18 lines, -24 lines 0 comments Download
M undocumented View 4 chunks +118 lines, -118 lines 0 comments Download

Messages

Total messages: 10
bcsaller
Please take a look.
5 years, 10 months ago (2013-01-31 14:17:27 UTC) #1
bcsaller
Please take a look.
5 years, 10 months ago (2013-01-31 17:16:43 UTC) #2
teknico
Land as is. See also some comments below. https://codereview.appspot.com/7228070/diff/3001/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/7228070/diff/3001/app/views/topology/service.js#newcode94 app/views/topology/service.js:94: // ...
5 years, 10 months ago (2013-02-01 15:35:08 UTC) #3
bcsaller
Please take a look.
5 years, 10 months ago (2013-02-01 15:58:29 UTC) #4
matthew.scott
Two things, one comment in code. Also encountered: attempting to destroy a service leads to ...
5 years, 10 months ago (2013-02-01 16:41:54 UTC) #5
bcsaller
On 2013/02/01 16:41:54, matthew.scott wrote: > Two things, one comment in code. > > Also ...
5 years, 10 months ago (2013-02-04 14:35:04 UTC) #6
bcsaller
https://codereview.appspot.com/7228070/diff/9001/app/views/topology/service.js File app/views/topology/service.js (right): https://codereview.appspot.com/7228070/diff/9001/app/views/topology/service.js#newcode342 app/views/topology/service.js:342: box.inDrag = 2; On 2013/02/01 16:41:54, matthew.scott wrote: > ...
5 years, 10 months ago (2013-02-04 14:35:10 UTC) #7
bcsaller
Please take a look.
5 years, 10 months ago (2013-02-04 14:37:43 UTC) #8
matthew.scott
Land as is, thank you!
5 years, 10 months ago (2013-02-04 20:13:47 UTC) #9
bcsaller
5 years, 10 months ago (2013-02-04 21:13:44 UTC) #10
*** Submitted:

Remove service click actions

This branch builds on the view model improvements to remove service click
actions, simplify the calling convention of methods that lived there and 
remove their dependencies on the service_click_actions closure.

R=teknico, matthew.scott
CC=
https://codereview.appspot.com/7228070
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b