code review 7228067: os: use signal strings where possible in ProcessState.String

os: use signal strings where possible in ProcessState.String

[rsc, 2013-01-31 06:58:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-01-31 07:17:46]

LGTM

On Wed, Jan 30, 2013 at 10:58 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> os: use signal strings where possible in ProcessState.String
>
> Please review this at
https://codereview.appspot.**com/7228067/<https://codereview.appspot.com/7228...
>
> Affected files:
>   M src/pkg/os/exec_posix.go
>
>
> Index: src/pkg/os/exec_posix.go
> ==============================**==============================**=======
> --- a/src/pkg/os/exec_posix.go
> +++ b/src/pkg/os/exec_posix.go
> @@ -118,9 +118,9 @@
>         case status.Exited():
>                 res = "exit status " + itod(status.ExitStatus())
>         case status.Signaled():
> -               res = "signal " + itod(int(status.Signal()))
> +               res = "signal: " + status.Signal().String()
>         case status.Stopped():
> -               res = "stop signal " + itod(int(status.StopSignal()))
> +               res = "stop signal: " + status.StopSignal().String()
>                 if status.StopSignal() == syscall.SIGTRAP &&
> status.TrapCause() != 0 {
>                         res += " (trap " + itod(status.TrapCause()) + ")"
>                 }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-01-31 15:53:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=0f7b57cebbc7 ***

os: use signal strings where possible in ProcessState.String

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7228067