Update the release checklists.

Update the release checklists.

Update the release checklists in docs/process.rst. Also:

- add two deprecation targets to the Makefile;
- clean up lib/server.js a little bit.

https://code.launchpad.net/~teknico/juju-gui/update-release-checklists/+merge/145937

(do not edit description out of merge proposal)

[teknico, 2013-01-31 18:08:14]

Please take a look.

[matthew.scott, 2013-01-31 18:24:03]

Land with changes (1.5 minors), or land as is if you disagree.  Thanks for the
work.

https://codereview.appspot.com/7227065/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode161
docs/process.rst:161: - Looking at the ``build-prod/juju-ui/version.js`` file
should show you a
"Ensure that the [...] file contains a version string[...]" might be a little
clearer.  I think it's good to be more forceful and declarative here, because if
the version.js file is wrong, then something messed up.

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode238
docs/process.rst:238: - Looking at the ``build-prod/juju-ui/version.js`` file
should show you a
As above

[gary.poster, 2013-02-01 02:44:15]

Land with changes.  Thank you very much for the important improvements.

Gary

https://codereview.appspot.com/7227065/diff/1/CHANGES.yaml
File CHANGES.yaml (left):

https://codereview.appspot.com/7227065/diff/1/CHANGES.yaml#oldcode24
CHANGES.yaml:24: - 0.2:
Why did you remove this stuff?  It looks good!

https://codereview.appspot.com/7227065/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/7227065/diff/1/Makefile#newcode154
Makefile:154: @echo "Other targets are available, see the Makefile."
Flyby: comma should be a colon (or a period and a new sentence).

https://codereview.appspot.com/7227065/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode160
docs/process.rst:160: and directories, especially in the ``node_modules/``
directory.
Good, thanks.  Did you ever figure out how that happened to you?

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode161
docs/process.rst:161: - Looking at the ``build-prod/juju-ui/version.js`` file
should show you a
On 2013/01/31 18:24:03, matthew.scott wrote:
> "Ensure that the [...] file contains a version string[...]" might be a little
> clearer.  I think it's good to be more forceful and declarative here, because
if
> the version.js file is wrong, then something messed up.

+1

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode184
docs/process.rst:184: could you disable 2FA on my staging account?")
Thank you

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode193
docs/process.rst:193: ``cmp`` command).
Good

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode196
docs/process.rst:196: staging, fix the problems and restart the process.
Add, "However, *do not* reuse the version number that you deleted.  A deleted is
a dead release, not an invisible one, and the next, fixed release should
increase the revision number."  Or something like that.

https://codereview.appspot.com/7227065/diff/1/lib/server.js
File lib/server.js (right):

https://codereview.appspot.com/7227065/diff/1/lib/server.js#newcode73
lib/server.js:73: // sending the 'shell' page which creates the `Y.App`
instance.
s/which/that/

Thanks for moving the comment to the right place. :-)

[teknico, 2013-02-01 09:46:58]

Thanks for the reviews, Matt and Gary.

https://codereview.appspot.com/7227065/diff/1/CHANGES.yaml
File CHANGES.yaml (left):

https://codereview.appspot.com/7227065/diff/1/CHANGES.yaml#oldcode24
CHANGES.yaml:24: - 0.2:
gary.poster wrote:
> Why did you remove this stuff?  It looks good!

It was not needed until the next release, but I'll need it shortly so I'll leave
it in there, with a more sensible release number (0.2.0).

https://codereview.appspot.com/7227065/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/7227065/diff/1/Makefile#newcode154
Makefile:154: @echo "Other targets are available, see the Makefile."
gary.poster wrote:
> Flyby: comma should be a colon (or a period and a new sentence).

Done.

https://codereview.appspot.com/7227065/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode160
docs/process.rst:160: and directories, especially in the ``node_modules/``
directory.
gary.poster wrote:
> Did you ever figure out how that happened to you?

Yes, and I am quite embarassed by it. I've been dragging along a node_modules/
directory from branch to branch for a while, to avoid that 90MB download each
time. It apparently was created when my umask was still 0027, or something. All
of this just to save some download time. You're entitled to call me Scrooge
McDuck from now on. :-P

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode161
docs/process.rst:161: - Looking at the ``build-prod/juju-ui/version.js`` file
should show you a
> matthew.scott wrote:
>> "Ensure that the [...] file contains a version string[...]"
>> might be a little clearer.  I think it's good to be more
>> forceful and declarative here, because if the version.js
>> file is wrong, then something messed up.

gary.poster wrote:
> +1

Done.

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode196
docs/process.rst:196: staging, fix the problems and restart the process.
gary.poster wrote:
> Add, "However, *do not* reuse the version number that you deleted.  
> A deleted is a dead release, not an invisible one, and the next,
> fixed release should increase the revision number."  Or something
> like that.

Done.

https://codereview.appspot.com/7227065/diff/1/docs/process.rst#newcode238
docs/process.rst:238: - Looking at the ``build-prod/juju-ui/version.js`` file
should show you a
matthew.scott wrote:
> As above

Done.

https://codereview.appspot.com/7227065/diff/1/lib/server.js
File lib/server.js (right):

https://codereview.appspot.com/7227065/diff/1/lib/server.js#newcode73
lib/server.js:73: // sending the 'shell' page which creates the `Y.App`
instance.
gary.poster wrote:
> s/which/that/

Done.

[teknico, 2013-02-01 10:02:33]

Please take a look.

[teknico, 2013-02-01 10:05:35]

*** Submitted:

Update the release checklists.

Update the release checklists in docs/process.rst. Also:

- add two deprecation targets to the Makefile;
- clean up lib/server.js a little bit.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7227065