Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1370)

Issue 72270046: code review 72270046: cmd/gc: enforce register-width alignment for stack sizes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by remyoudompheng
Modified:
10 years, 1 month ago
Reviewers:
gobot, rsc
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

cmd/gc: enforce register-width alignment for stack sizes. This fixes the following amd64p32 issue: pkg/time/format.go:724: internal compiler error: twobitwalktype1: invalid initial alignment, Time caused by the pointer zone ending on a 32-bit-aligned boundary.

Patch Set 1 #

Patch Set 2 : diff -r d763454383f4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d763454383f4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ef9dd517f626 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/gc/pgen.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello rsc@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 1 month ago (2014-03-07 19:18:42 UTC) #1
rsc
LGTM
10 years, 1 month ago (2014-03-07 19:22:35 UTC) #2
remyoudompheng
*** Submitted as https://code.google.com/p/go/source/detail?r=03e5b26282f7 *** cmd/gc: enforce register-width alignment for stack sizes. This fixes the ...
10 years, 1 month ago (2014-03-07 19:28:23 UTC) #3
gobot
10 years, 1 month ago (2014-03-08 02:11:07 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the darwin-386-cheney builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b