state: add user support

state: add user support

As agreed, we're not implementing removal
of users at this time.

https://code.launchpad.net/~rogpeppe/juju-core/206-state-entity/+merge/145443

(do not edit description out of merge proposal)

[rog, 2013-01-29 17:29:34]

Please take a look.

[dimitern, 2013-01-30 06:47:22]

LGTM, one question.

https://codereview.appspot.com/7226056/diff/2001/state/user.go
File state/user.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode11
state/user.go:11: var validUser = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9]*$")
How about enforcing some minimum length for passwords, like 8 chars?

[TheMue, 2013-01-30 15:51:52]

LGTM, only three comments.

https://codereview.appspot.com/7226056/diff/2001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/state.go#newcode253
state/state.go:253: // Entity represents an entity that has
s/Entity/AuthEntity/

https://codereview.appspot.com/7226056/diff/2001/state/user.go
File state/user.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode11
state/user.go:11: var validUser = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9]*$")
On 2013/01/30 06:47:22, dimitern wrote:
> How about enforcing some minimum length for passwords, like 8 chars?

Not sure about a pw validation here in state. Often they restrict in bad way
(e.g. length limitation or usage or special characters).

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode43
state/user.go:43: func (st *State) getUser(name string, udoc *userDoc) error {
Would like to drop the get-prefix, as  we have almost no methods with it.

[fwereade, 2013-01-31 13:08:56]

LGTM on the understanding that the PasswordHash never actually goes down to a
client.

https://codereview.appspot.com/7226056/diff/2001/state/user.go
File state/user.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode43
state/user.go:43: func (st *State) getUser(name string, udoc *userDoc) error {
On 2013/01/30 15:51:52, TheMue wrote:
> Would like to drop the get-prefix, as  we have almost no methods with it.

We have relatively few methods that would require it, though -- I'm +1 on
getUser

[rog, 2013-01-31 18:06:51]

*** Submitted:

state: add user support

As agreed, we're not implementing removal
of users at this time.

R=dimitern, TheMue, fwereade
CC=
https://codereview.appspot.com/7226056

https://codereview.appspot.com/7226056/diff/2001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/state.go#newcode253
state/state.go:253: // Entity represents an entity that has
On 2013/01/30 15:51:52, TheMue wrote:
> s/Entity/AuthEntity/

Done.

https://codereview.appspot.com/7226056/diff/2001/state/user.go
File state/user.go (right):

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode11
state/user.go:11: var validUser = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9]*$")
On 2013/01/30 15:51:52, TheMue wrote:
> On 2013/01/30 06:47:22, dimitern wrote:
> > How about enforcing some minimum length for passwords, like 8 chars?
> 
> Not sure about a pw validation here in state. Often they restrict in bad way
> (e.g. length limitation or usage or special characters).

+1
if we want password validation, the right place is somewhere user facing.

https://codereview.appspot.com/7226056/diff/2001/state/user.go#newcode43
state/user.go:43: func (st *State) getUser(name string, udoc *userDoc) error {
On 2013/01/31 13:08:56, fwereade wrote:
> On 2013/01/30 15:51:52, TheMue wrote:
> > Would like to drop the get-prefix, as  we have almost no methods with it.
> 
> We have relatively few methods that would require it, though -- I'm +1 on
> getUser

thanks. i think getUser is as good as readUser which is what i'd use otherwise.