Get rid of the global DB object

Get rid of the global DB object

This is very simple fix; the solution as described in
http://docs.pylonsproject.org/projects/pyramid_cookbook/en/latest/database/mongodb.html
turns out to be a bit more complicated: Creating the DB object in
a NewRequest event does not work for unit tests derived from ViewTestBase
because charmworld.main() is not called for these tests.

https://code.launchpad.net/~adeuring/charmworld/no-global-db-obj-2/+merge/145206

(do not edit description out of merge proposal)

[abel.deuring, 2013-01-28 16:36:28]

Please take a look.

[rharding, 2013-01-28 16:41:48]

lgtm to me, I think this addresses the desire to not have a global db handler in
the module. One suggestion on naming for clarity.

Thanks

https://codereview.appspot.com/7226049/diff/1/charmworld/models.py
File charmworld/models.py (right):

https://codereview.appspot.com/7226049/diff/1/charmworld/models.py#newcode5
charmworld/models.py:5: _juju_db = None
Since this is just a string name maybe _juju_name would be more clear that it's
not actually a db here, just a description.

[hazmat, 2013-01-28 16:57:05]

the tests should separately setup the db connection and subscriber ala

http://pylons.readthedocs.org/projects/pyramid/en/latest/api/config.html#pyra...


as is the branch doesn't really get rid of the global, just substitutes a global
ref for an attribute access on another global ref.