Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 72260045: code review 72260045: cmd/gc: correct GOARCH in object files for amd64p32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by remyoudompheng
Modified:
11 years, 3 months ago
Reviewers:
dave
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

cmd/gc: correct GOARCH in object files for amd64p32.

Patch Set 1 #

Patch Set 2 : diff -r 26aa53304a48 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26aa53304a48 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a6c2234663f1 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/obj.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello rsc@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2014-03-07 22:08:17 UTC) #1
dave_cheney.net
LGTM. I saw that error earlier, I'm glad the fix was simple. > On 8 ...
11 years, 3 months ago (2014-03-07 22:16:51 UTC) #2
remyoudompheng
11 years, 3 months ago (2014-03-07 22:18:11 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f7021118727a ***

cmd/gc: correct GOARCH in object files for amd64p32.

LGTM=dave
R=rsc, dave
CC=golang-codereviews
https://codereview.appspot.com/72260045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b