code review 7225074: cmd/go: many bug fixes

cmd/go: many bug fixes

* Reject import paths of the form cmd/x/y.
* Reject 'go install' of command outside GOPATH
* Clearer error rejecting 'go install' of package outside GOPATH.
* Name temporary binary for first file in 'go run' list or for test.
* Provide a way to pass -ldflags arguments with spaces.
* Pass all Go files (even +build ignored ones) to go fix, go fmt, go vet.
* Reject 'go run foo_test.go'.
* Silence 'exit 1' prints from 'go tool' invocations.
* Make go test -xxxprofile leave binary behind for analysis.
* Reject ~ in GOPATH except on Windows.
* Get a little less confused by symlinks.
* Document that go test x y z runs three test binaries.
* Fix go test -timeout=0.
* Add -tags flag to 'go list'.
* Use pkg/gccgo_$GOOS_$GOARCH for gccgo output.

Fixes issue 3389.
Fixes issue 3500.
Fixes issue 3503.
Fixes issue 3760.
Fixes issue 3941.
Fixes issue 4007.
Fixes issue 4032.
Fixes issue 4074.
Fixes issue 4127.
Fixes issue 4140.
Fixes issue 4311.
Fixes issue 4568.
Fixes issue 4576.
Fixes issue 4702.

[rsc, 2013-01-31 06:59:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[adg, 2013-01-31 07:07:59]

Don't forget to run mkdoc.sh to bring doc.go up to speed.

[adg, 2013-01-31 07:21:43]

The code all LGTM, but I'm not thrilled that this is one big ball of fixes (and
a new feature!) in one CL. Care to split it up?

https://codereview.appspot.com/7225074/diff/2001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

https://codereview.appspot.com/7225074/diff/2001/src/pkg/go/build/build.go#ne...
src/pkg/go/build/build.go:319: IgnoredGoFiles []string // .go source files
ignored for this build
gofmt?

[rsc, 2013-01-31 07:22:56]

On 2013/01/31 07:21:43, adg wrote:
> The code all LGTM, but I'm not thrilled that this is one big ball of fixes
(and
> a new feature!) in one CL. Care to split it up?

No thanks, I'm going to bed. If I split it up it will take 15 round trips.

[adg, 2013-01-31 07:26:54]

On 31 January 2013 18:22, <rsc@golang.org> wrote:

> No thanks, I'm going to bed. If I split it up it will take 15 round
> trips.
>

Not asking for you to split it into 15. At least put -tags into a separate
change. Or don't. Whatever.

I'm just glad the issues are fixed.

[rsc, 2013-01-31 07:34:39]

On Wed, Jan 30, 2013 at 11:26 PM, Andrew Gerrand <adg@golang.org> wrote:

> On 31 January 2013 18:22, <rsc@golang.org> wrote:
>
>> No thanks, I'm going to bed. If I split it up it will take 15 round
>> trips.
>>
>
> Not asking for you to split it into 15. At least put -tags into a separate
> change.
>

They're all pretty small fixes. Even go list -tags is a bug fix: the flag
was just missing in that subcommand, making it impossible to debug problems
with go build -tags and go install -tags (which already existed).

Russ

[adg, 2013-01-31 08:03:05]

LGTM

Okay.

[rsc, 2013-01-31 16:06:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=58e1987657d6 ***

cmd/go: many bug fixes

* Reject import paths of the form cmd/x/y.
* Reject 'go install' of command outside GOPATH
* Clearer error rejecting 'go install' of package outside GOPATH.
* Name temporary binary for first file in 'go run' list or for test.
* Provide a way to pass -ldflags arguments with spaces.
* Pass all Go files (even +build ignored ones) to go fix, go fmt, go vet.
* Reject 'go run foo_test.go'.
* Silence 'exit 1' prints from 'go tool' invocations.
* Make go test -xxxprofile leave binary behind for analysis.
* Reject ~ in GOPATH except on Windows.
* Get a little less confused by symlinks.
* Document that go test x y z runs three test binaries.
* Fix go test -timeout=0.
* Add -tags flag to 'go list'.
* Use pkg/gccgo_$GOOS_$GOARCH for gccgo output.

Fixes issue 3389.
Fixes issue 3500.
Fixes issue 3503.
Fixes issue 3760.
Fixes issue 3941.
Fixes issue 4007.
Fixes issue 4032.
Fixes issue 4074.
Fixes issue 4127.
Fixes issue 4140.
Fixes issue 4311.
Fixes issue 4568.
Fixes issue 4576.
Fixes issue 4702.

R=adg
CC=golang-dev
https://codereview.appspot.com/7225074