Issue 7225070: code review 7225070: cmd/godoc: fix buggy use of strings.HasSuffix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7225070: code review 7225070: cmd/godoc: fix buggy use of strings.HasSuffix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bradfitz

Modified:
12 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/godoc: fix buggy use of strings.HasSuffix This code never worked. Maybe it's not necessary?

Patch Set 1 #

Patch Set 2 : diff -r b90cad8349e0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b90cad8349e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 85014abe1574 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/cmd/godoc/godoc.go	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2013-01-30 19:46:03 UTC) #1

rsc

LGTM The code is necessary, it's just broken. golang.org seems to be working correctly but ...

12 years, 5 months ago (2013-01-30 19:52:09 UTC) #2

bradfitz

12 years, 5 months ago (2013-01-30 20:30:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=59521f9a2f0f ***

cmd/godoc: fix buggy use of strings.HasSuffix

This code never worked. Maybe it's not necessary?

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7225070

Expand All Messages | Collapse All Messages