Issue 7225059: dwarfpc: fix null pointer dereference

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7225059: dwarfpc: fix null pointer dereference

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by xi

Modified:
11 years, 11 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Description

The result of realloc() is not assigned to f; f remains nil.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/libmach/dwarfpc.c	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

11 years, 11 months ago (2013-01-31 01:46:15 UTC) #2

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=2bf22a0774a7 ***

libmach: fix crash in dwarfpc (misuse of realloc)

R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7225059

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages