Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(403)

Issue 72240045: code review 72240045: runtime: add missing nacl build tag for lock_sema.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by remyoudompheng
Modified:
11 years, 3 months ago
Reviewers:
gobot, dave
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

runtime: add missing nacl build tag for lock_sema.c

Patch Set 1 #

Patch Set 2 : diff -r 26aa53304a48 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26aa53304a48 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 26aa53304a48 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/lock_sema.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello rsc@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2014-03-07 22:12:28 UTC) #1
dave_cheney.net
LGTM. > On 8 Mar 2014, at 9:12, remyoudompheng@gmail.com wrote: > > Reviewers: rsc, dfc, ...
11 years, 3 months ago (2014-03-07 22:16:21 UTC) #2
remyoudompheng
*** Submitted as https://code.google.com/p/go/source/detail?r=a6c2234663f1 *** runtime: add missing nacl build tag for lock_sema.c LGTM=dave R=rsc, ...
11 years, 3 months ago (2014-03-07 22:17:48 UTC) #3
gobot
11 years, 3 months ago (2014-03-07 23:15:07 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b