provider/maas: apt-get install bridge-utils

provider/maas: apt-get install bridge-utils

Previously we added bridge-utils to the required packages
in environs/cloudinit, but at bootstrap time, those packages
are not installed before the additional commands specified
by a provider are run (we want any failures to
be visible, so we wait until the synchronous part of the
bootstrap process).

To fix this, we explicitly add "apt-get install bridge-utils"
to provider/maas and remove it from environs/cloudinit.

Fixes:

https://bugs.launchpad.net/juju-core/+bug/1271144
https://bugs.launchpad.net/juju-core/+bug/1277359

https://code.launchpad.net/~rogpeppe/juju-core/512-maas-bootstrap-bridge-utils/+merge/209885

(do not edit description out of merge proposal)

[rog, 2014-03-07 12:21:24]

Please take a look.

[fwereade, 2014-03-07 12:34:32]

On 2014/03/07 12:21:24, rog wrote:
> Please take a look.

I has a sad about the lack of tests.

[axw, 2014-03-07 13:19:25]

On 2014/03/07 12:34:32, fwereade wrote:
> On 2014/03/07 12:21:24, rog wrote:
> > Please take a look.
> 
> I has a sad about the lack of tests.

Apart from this, looks good.

You might be able to knock this one off at the same time, but feel free to
ignore me: https://bugs.launchpad.net/maas/+bug/1248283

(We should be using ifdown/ifup, rather than "service networking restart")

[gz, 2014-03-07 16:28:42]

Not sure this is landable as is.

https://codereview.appspot.com/72230045/diff/20001/provider/maas/environ.go
File provider/maas/environ.go (right):

https://codereview.appspot.com/72230045/diff/20001/provider/maas/environ.go#n...
provider/maas/environ.go:271: "apt-get install bridge-utils",
This misses the niceties of utils/apt.go aptGetCommand, some of which like -y
are really requirements. We should try to share good apt practices across the
code base.

It also will not play nicely with Wayne's in-progress change to make sure we try
to install packages-for-juju from the cloud-archive where possible:

https://code.launchpad.net/~wwitzel3/juju-core/lp-1289316-lxc-maas-precise