Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1135)

Issue 7221086: This change adds support for the multiply blend mode

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by RikC
Modified:
1 year, 2 months ago
Reviewers:
caryclark1;reed, Stephen White, senorblanco, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change adds support for the multiply blend mode

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M gm/xfermodes.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +20 lines, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 2 5 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 16
reed1
Looks clean. The impl in SkXfermode (of multiply_proc) looks faster than what was in SkBlendImageFilter. ...
1 year, 2 months ago #1
RikC
On 2013/02/01 20:11:29, reed1 wrote: > Looks clean. > > The impl in SkXfermode (of ...
1 year, 2 months ago #2
reed1
something like static void multiply_proc(...) { #ifdef SK_IGNORE_MULTIPLY_XFERMODE_OPT ... put the current code from SkBlendImageFilter ...
1 year, 2 months ago #3
Stephen White
On 2013/02/01 20:13:56, RikC wrote: > On 2013/02/01 20:11:29, reed1 wrote: > > Looks clean. ...
1 year, 2 months ago #4
RikC
> > Then put something in the patch description reminding us to #define > SK_USE_OLD_MULTIPLY_BLENDMODE ...
1 year, 2 months ago #5
Stephen White
On 2013/02/01 21:04:28, RikC wrote: > > > > Then put something in the patch ...
1 year, 2 months ago #6
Stephen White
On 2013/02/01 21:10:17, Stephen White wrote: > On 2013/02/01 21:04:28, RikC wrote: > > > ...
1 year, 2 months ago #7
Stephen White
On 2013/02/01 21:12:07, Stephen White wrote: > On 2013/02/01 21:10:17, Stephen White wrote: > > ...
1 year, 2 months ago #8
RikC
> > > > Hmm. Perhaps we should also augment the xfermodes GM's to exercise ...
1 year, 2 months ago #9
Stephen White
On 2013/02/01 21:19:55, RikC wrote: > > > > > > Hmm. Perhaps we should ...
1 year, 2 months ago #10
reed1
+1 for adding kMultiply to the gm/xfermodes
1 year, 2 months ago #11
RikC
On 2013/02/01 21:34:45, reed1 wrote: > +1 for adding kMultiply to the gm/xfermodes Done
1 year, 2 months ago #12
Stephen White
On 2013/02/01 21:37:17, RikC wrote: > On 2013/02/01 21:34:45, reed1 wrote: > > +1 for ...
1 year, 2 months ago #13
RikC
> New patch LGTM Can you commit it?
1 year, 2 months ago #14
reed1
I will commit this.
1 year, 2 months ago #15
reed1
1 year, 2 months ago #16
landed in 7553
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5