Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 7221086: This change adds support for the multiply blend mode

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by RikC
Modified:
2 years, 1 month ago
Reviewers:
caryclark1;reed, Stephen White, senorblanco, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change adds support for the multiply blend mode

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M gm/xfermodes.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +20 lines, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 2 5 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 16
reed1
Looks clean. The impl in SkXfermode (of multiply_proc) looks faster than what was in SkBlendImageFilter. ...
2 years, 1 month ago (2013-02-01 20:11:29 UTC) #1
RikC
On 2013/02/01 20:11:29, reed1 wrote: > Looks clean. > > The impl in SkXfermode (of ...
2 years, 1 month ago (2013-02-01 20:13:56 UTC) #2
reed1
something like static void multiply_proc(...) { #ifdef SK_IGNORE_MULTIPLY_XFERMODE_OPT ... put the current code from SkBlendImageFilter ...
2 years, 1 month ago (2013-02-01 20:18:16 UTC) #3
Stephen White
On 2013/02/01 20:13:56, RikC wrote: > On 2013/02/01 20:11:29, reed1 wrote: > > Looks clean. ...
2 years, 1 month ago (2013-02-01 20:24:42 UTC) #4
RikC
> > Then put something in the patch description reminding us to #define > SK_USE_OLD_MULTIPLY_BLENDMODE ...
2 years, 1 month ago (2013-02-01 21:04:28 UTC) #5
Stephen White
On 2013/02/01 21:04:28, RikC wrote: > > > > Then put something in the patch ...
2 years, 1 month ago (2013-02-01 21:10:17 UTC) #6
Stephen White
On 2013/02/01 21:10:17, Stephen White wrote: > On 2013/02/01 21:04:28, RikC wrote: > > > ...
2 years, 1 month ago (2013-02-01 21:12:07 UTC) #7
Stephen White
On 2013/02/01 21:12:07, Stephen White wrote: > On 2013/02/01 21:10:17, Stephen White wrote: > > ...
2 years, 1 month ago (2013-02-01 21:12:50 UTC) #8
RikC
> > > > Hmm. Perhaps we should also augment the xfermodes GM's to exercise ...
2 years, 1 month ago (2013-02-01 21:19:55 UTC) #9
Stephen White
On 2013/02/01 21:19:55, RikC wrote: > > > > > > Hmm. Perhaps we should ...
2 years, 1 month ago (2013-02-01 21:27:48 UTC) #10
reed1
+1 for adding kMultiply to the gm/xfermodes
2 years, 1 month ago (2013-02-01 21:34:45 UTC) #11
RikC
On 2013/02/01 21:34:45, reed1 wrote: > +1 for adding kMultiply to the gm/xfermodes Done
2 years, 1 month ago (2013-02-01 21:37:17 UTC) #12
Stephen White
On 2013/02/01 21:37:17, RikC wrote: > On 2013/02/01 21:34:45, reed1 wrote: > > +1 for ...
2 years, 1 month ago (2013-02-01 21:37:46 UTC) #13
RikC
> New patch LGTM Can you commit it?
2 years, 1 month ago (2013-02-01 23:33:06 UTC) #14
reed1
I will commit this.
2 years, 1 month ago (2013-02-04 17:09:19 UTC) #15
reed1
2 years, 1 month ago (2013-02-04 20:16:14 UTC) #16
landed in 7553
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5