code review 7221082: cmd/dist: redirect acid output to file to separate from...

cmd/dist: redirect acid output to file to separate from errors

If runtime's proc.c does not compile, cmd/dist used to show
the compile errors in a sea of acid output, making them impossible
to find. Change the command invocation to write the acid output
to a file, so that the errors are the only thing shown on failure.

[rsc, 2013-02-01 05:02:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-02-01 05:57:18]

LGTM

https://codereview.appspot.com/7221082/diff/7001/src/cmd/dist/buildruntime.c
File src/cmd/dist/buildruntime.c (right):

https://codereview.appspot.com/7221082/diff/7001/src/cmd/dist/buildruntime.c#...
src/cmd/dist/buildruntime.c:221: vadd(&argv, "-n");
This -n option is not in the comment above.

[rsc, 2013-02-01 06:01:52]

Done. It was a surprise to me too.
(-n means actually write to the -o file instead of stdout.)

[rsc, 2013-02-01 06:02:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=10d1582a1129 ***

cmd/dist: redirect acid output to file to separate from errors

If runtime's proc.c does not compile, cmd/dist used to show
the compile errors in a sea of acid output, making them impossible
to find. Change the command invocation to write the acid output
to a file, so that the errors are the only thing shown on failure.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7221082