Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)

Issue 7221075: code review 7221075: encoding/xml: add (*Encoder).Indent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rsc
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, rog
Visibility:
Public.

Description

encoding/xml: add (*Encoder).Indent Exposing this on the Encoder allows streaming generation of indented XML.

Patch Set 1 #

Patch Set 2 : diff -r 715674f61ae8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 715674f61ae8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c8cd1f608cd2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M src/pkg/encoding/xml/example_test.go View 1 1 chunk +40 lines, -0 lines 0 comments Download
M src/pkg/encoding/xml/marshal.go View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 2 months ago (2013-01-30 15:23:37 UTC) #1
rog
On 2013/01/30 15:23:37, rsc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
11 years, 2 months ago (2013-01-30 15:50:47 UTC) #2
rsc
11 years, 2 months ago (2013-01-30 15:57:23 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4346c244291a ***

encoding/xml: add (*Encoder).Indent

Exposing this on the Encoder allows streaming generation of indented XML.

R=golang-dev, rogpeppe
CC=golang-dev
https://codereview.appspot.com/7221075
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b