Local provider flag for fast-lxc

Local provider flag for fast-lxc

The flag is determined by the distro release from the
/etc/lsb-release file.

There is an override environment variable that can be
set to keep existing behaviour.  Although no actual
behaviour is introduced in this branch.

https://code.launchpad.net/~thumper/juju-core/fast-lxc/+merge/209801

Requires: https://code.launchpad.net/~thumper/juju-core/maybe-add-cloud-archive-func/+merge/209798

(do not edit description out of merge proposal)

[thumper, 2014-03-06 22:15:02]

Please take a look.

[sidnei.da.silva, 2014-03-06 23:20:15]

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go
File provider/local/lxc.go (right):

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go#newcode38
provider/local/lxc.go:38: return value >= 14.04
Is it possible at all to do a feature check instead of a version check here
(even if it means parsing lxc-create --help)? It should technically be possible
to use fast lxc if you have a backport of lxc 1.0 for anything between precise
and trusty.

[wallyworld, 2014-03-06 23:24:18]

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go
File provider/local/lxc.go (right):

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go#newcode44
provider/local/lxc.go:44: func getReleaseVersion() string {
There's a method in version.go which reads the series from lsb-release -
readSeries(). I think it would be best to enhance this function to return
version also or otherwise put this functionality there and export it, so that
the version related stuff is kept together.

[thumper, 2014-03-07 03:56:19]

On 2014/03/06 23:20:15, sidnei.da.silva wrote:
> https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go
> File provider/local/lxc.go (right):
> 
> https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go#newcode38
> provider/local/lxc.go:38: return value >= 14.04
> Is it possible at all to do a feature check instead of a version check here
> (even if it means parsing lxc-create --help)? It should technically be
possible
> to use fast lxc if you have a backport of lxc 1.0 for anything between precise
> and trusty.

While technically possible, it seemed reasonable to me and others to keep it
simple and say this is a trusty feature.

[thumper, 2014-03-07 04:27:34]

Please take a look.

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go
File provider/local/lxc.go (right):

https://codereview.appspot.com/72210043/diff/1/provider/local/lxc.go#newcode44
provider/local/lxc.go:44: func getReleaseVersion() string {
On 2014/03/06 23:24:19, wallyworld wrote:
> There's a method in version.go which reads the series from lsb-release -
> readSeries(). I think it would be best to enhance this function to return
> version also or otherwise put this functionality there and export it, so that
> the version related stuff is kept together.

Moved.

[fwereade, 2014-03-07 12:29:48]

really messy diff, please repropose

[thumper, 2014-03-09 20:59:25]

Please take a look.

[wallyworld, 2014-03-11 00:49:33]

LGTM