Issue 7214047: GUI should handle reconnects gracefully.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7214047: GUI should handle reconnects gracefully.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by matthew.scott

Modified:
11 years, 3 months ago

Reviewers:
mp+145022

Visibility:
Public.

Description

GUI should handle reconnects gracefully. Previously, the GUI would lose its mind on a reconnect, due to the addition of authentication and not receiving a delta. This has been fixed, and the existing test for connection behavior modified to reflect changes. https://code.launchpad.net/~makyo/juju-gui/gui-loses-its-mind-1098591/+merge/145022 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : GUI should handle reconnects gracefully. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/test_app.js	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

matthew.scott

11 years, 3 months ago (2013-01-28 15:20:19 UTC) #4

*** Submitted:

GUI should handle reconnects gracefully.

Previously, the GUI would lose its mind on a reconnect, due to the addition of
authentication and not receiving a delta.  This has been fixed, and the existing
test for connection behavior modified to reflect changes.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/7214047

Expand All Messages | Collapse All Messages