Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(422)

Issue 7213044: code review 7213044: exp/locale/collate: moved low-level collation functionality (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by mpvl
Modified:
11 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

exp/locale/collate: moved low-level collation functionality into separate package. This allows this code to be shared with the search package without the need for these two to use the same tables. Adjusted various files accordingly.

Patch Set 1 #

Patch Set 2 : diff -r 85014abe1574 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 9e8eec6e3239 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -540 lines) Patch
M src/pkg/exp/locale/collate/build/builder.go View 1 2 6 chunks +20 lines, -18 lines 0 comments Download
M src/pkg/exp/locale/collate/build/colelem.go View 1 6 chunks +18 lines, -90 lines 0 comments Download
M src/pkg/exp/locale/collate/build/colelem_test.go View 1 5 chunks +16 lines, -16 lines 0 comments Download
M src/pkg/exp/locale/collate/build/order.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/exp/locale/collate/build/order_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/exp/locale/collate/collate.go View 1 2 17 chunks +29 lines, -27 lines 0 comments Download
M src/pkg/exp/locale/collate/collate_test.go View 1 2 13 chunks +205 lines, -121 lines 0 comments Download
M src/pkg/exp/locale/collate/colltab/colelem.go View 1 2 4 chunks +74 lines, -22 lines 0 comments Download
M src/pkg/exp/locale/collate/colltab/colelem_test.go View 1 2 4 chunks +2 lines, -114 lines 0 comments Download
M src/pkg/exp/locale/collate/colltab/colltab.go View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/pkg/exp/locale/collate/colltab/contract.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/locale/collate/colltab/contract_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/locale/collate/colltab/export.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/locale/collate/colltab/table.go View 1 2 4 chunks +5 lines, -48 lines 0 comments Download
M src/pkg/exp/locale/collate/colltab/trie.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/locale/collate/colltab/trie_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/locale/collate/export_test.go View 1 2 3 chunks +12 lines, -52 lines 0 comments Download
A src/pkg/exp/locale/collate/index.go View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M src/pkg/exp/locale/collate/maketables.go View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/pkg/exp/locale/collate/regtest.go View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M src/pkg/exp/locale/collate/table_test.go View 1 2 4 chunks +18 lines, -13 lines 0 comments Download
M src/pkg/exp/locale/collate/tables.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mpvl
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
11 years, 2 months ago (2013-01-30 20:45:37 UTC) #1
rsc
LGTM I glazed over after the first few files. Assuming it's mainly the move.
11 years, 2 months ago (2013-01-30 20:59:06 UTC) #2
mpvl
11 years, 2 months ago (2013-02-12 15:00:02 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=d89c5a625fb5 ***

exp/locale/collate: moved low-level collation functionality
into separate package.  This allows this code to be shared
with the search package without the need for these two to use
the same tables.
Adjusted various files accordingly.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7213044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b