Issue 72080044: code review 72080044: encoding/asn1: use GeneralizedTime for times outside th...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72080044: code review 72080044: encoding/asn1: use GeneralizedTime for times outside th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by agl1

Modified:
11 years, 2 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

encoding/asn1: use GeneralizedTime for times outside the range of UTCTime. Fixes issue #6976.

Patch Set 1 #

Patch Set 2 : diff -r 1a0714819799 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ec6ee3cf226b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 436769b97f80 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 321d42ff40d3 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -11 lines)			Patch
M	src/pkg/crypto/tls/generate_cert.go	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/pkg/encoding/asn1/asn1.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/asn1/marshal.go	View	1 2 3	5 chunks	+46 lines, -3 lines	0 comments	Download
M	src/pkg/encoding/asn1/marshal_test.go	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2014-03-20 22:27:58 UTC) #1

agl1

11 years, 2 months ago (2014-03-21 15:14:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=c8ea7ed4a7c0 ***

encoding/asn1: use GeneralizedTime for times outside the range of UTCTime.

Fixes issue #6976.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/72080044

Expand All Messages | Collapse All Messages