Add a test for the fix for bug 1103204

Add a test for the fix for bug 1103204

This branch also includes some refactoring of where relation names are
calculated in an effort to DRY it up as well as make testing a tad easier.

https://code.launchpad.net/~benji/juju-gui/bug-1103477/+merge/144594

(do not edit description out of merge proposal)

[benji, 2013-01-23 22:09:47]

Please take a look.

[matthew.scott, 2013-01-23 22:44:27]

Land as is after landing parent branch, looks good to me with the change
involved in the parent.

[gary.poster, 2013-01-24 04:55:26]

Land with changes.

Extremely nice branch, Benji.  Thank you.

Gary

https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:834: relationClick: function(d, self) {
I expected you to change this "d" argument to "relation" like your other nice
changes.  Would be nice. :-)

https://codereview.appspot.com/7206047/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/7206047/diff/1/app/views/utils.js#newcode827
app/views/utils.js:827: * Decorate a relation with some related/derrived data.
typo: derived

[benji, 2013-01-24 19:31:58]

*** Submitted:

Add a test for the fix for bug 1103204

This branch also includes some refactoring of where relation names are
calculated in an effort to DRY it up as well as make testing a tad easier.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7206047

https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:834: relationClick: function(d, self) {
On 2013/01/24 04:55:27, gary.poster wrote:
> I expected you to change this "d" argument to "relation" like your other nice
> changes.  Would be nice. :-)

There are so many "d"s that I didn't want to change them all, but since you
asked nicely...

https://codereview.appspot.com/7206047/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/7206047/diff/1/app/views/utils.js#newcode827
app/views/utils.js:827: * Decorate a relation with some related/derrived data.
On 2013/01/24 04:55:27, gary.poster wrote:
> typo: derived

Done.