state: peer relation lifecycle

state: peer relation lifecycle

Services that define peer relations now always have peer relations -- they
can no longer be created or destroyed directly (well, they could be created;
but real ones will already exist, and fake relations will be removed in a
followup).

https://code.launchpad.net/~fwereade/juju-core/peer-relation-lifecycle/+merge/144975

Requires: https://code.launchpad.net/~fwereade/juju-core/state-test-sane-endpoints/+merge/144767

(do not edit description out of merge proposal)

[fwereade, 2013-01-25 16:28:47]

Please take a look.

[TheMue, 2013-01-25 16:39:06]

LGTM

[rog, 2013-01-25 17:07:54]

LGTM with one fix needed and one trivial remark.

https://codereview.appspot.com/7205058/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/7205058/diff/1/environs/jujutest/livetests.go#...
environs/jujutest/livetests.go:366: svc, err := conn.State.AddService("", sch)
how can this have passed the tests? "" isn't a valid service name.

https://codereview.appspot.com/7205058/diff/1/state/state.go
File state/state.go (right):

https://codereview.appspot.com/7205058/diff/1/state/state.go#newcode326
state/state.go:326: relOps := []txn.Op{}
create svcOps here (but call it "ops") ?
(see below)

https://codereview.appspot.com/7205058/diff/1/state/state.go#newcode363
state/state.go:363: svcOps := []txn.Op{{
if you created this first, then the loop above could continue appending to the
same ops slice. slightly simpler code.

[fwereade, 2013-01-25 21:48:47]

*** Submitted:

state: peer relation lifecycle

Services that define peer relations now always have peer relations -- they
can no longer be created or destroyed directly (well, they could be created;
but real ones will already exist, and fake relations will be removed in a
followup).

R=TheMue, rog
CC=
https://codereview.appspot.com/7205058

https://codereview.appspot.com/7205058/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/7205058/diff/1/environs/jujutest/livetests.go#...
environs/jujutest/livetests.go:366: svc, err := conn.State.AddService("", sch)
On 2013/01/25 17:07:54, rog wrote:
> how can this have passed the tests? "" isn't a valid service name.

Done.