Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(209)

Issue 7205051: [TRIVAL] Fix for missing navigateTo handler

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bcsaller
Modified:
11 years, 3 months ago
Reviewers:
mp+144813
Visibility:
Public.

Description

[TRIVAL] Fix for missing navigateTo handler Fix for badly pruned code with additional test. https://code.launchpad.net/~bcsaller/juju-gui/navto-fix/+merge/144813 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : [TRIVAL] Fix for missing navigateTo handler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/test_service_module.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bcsaller
Please take a look.
11 years, 3 months ago (2013-01-24 21:30:52 UTC) #1
matthew.scott
Land as is; thanks for the quick fix!
11 years, 3 months ago (2013-01-24 21:43:58 UTC) #2
frankban
Land as is. Thanks for this fix and for the test!
11 years, 3 months ago (2013-01-25 12:16:08 UTC) #3
bcsaller
11 years, 3 months ago (2013-01-25 12:40:19 UTC) #4
*** Submitted:

[TRIVAL] Fix for missing navigateTo handler

Fix for badly pruned code with additional test.

R=matthew.scott, frankban
CC=
https://codereview.appspot.com/7205051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b