Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(696)

Issue 7205044: Fixes for bug #1103035.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by frankban
Modified:
11 years, 3 months ago
Reviewers:
mp+144552
Visibility:
Public.

Description

Fixes for bug #1103035. Add the "curl" package as an install dependency: some OS images may not include it by default. Remove the "user" and "password" options from the "config.yaml" file. Those credentials are easily discoverable and insecure. The code still hardwires bypassing the authenticating step when deploying to staging. Move the "maintainer" line to below the "summary" one in "metadata.yaml". README file: - list the currently supported web browsers; - explain the self-signed certificate workaround currently needed to make Firefox work; - anonymize the EC2 addresses. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1103035-charm-fixes/+merge/144552 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes for bug #1103035. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -85 lines) Patch
M README.md View 2 chunks +18 lines, -6 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 chunk +0 lines, -14 lines 0 comments Download
M hooks/config-changed View 1 chunk +4 lines, -6 lines 0 comments Download
M hooks/install View 1 chunk +1 line, -1 line 0 comments Download
M hooks/start View 1 chunk +3 lines, -3 lines 0 comments Download
M hooks/utils.py View 4 chunks +3 lines, -18 lines 0 comments Download
M metadata.yaml View 1 chunk +1 line, -1 line 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 3 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
11 years, 3 months ago (2013-01-23 18:13:13 UTC) #1
gary.poster
Land as is, assuming tests pass and manual qa works. Thank you!
11 years, 3 months ago (2013-01-23 18:20:39 UTC) #2
matthew.scott
Looks good to me! Land as is, and thanks!
11 years, 3 months ago (2013-01-23 19:06:09 UTC) #3
frankban
11 years, 3 months ago (2013-01-24 09:37:56 UTC) #4
*** Submitted:

Fixes for bug #1103035.

Add the "curl" package as an install dependency: some OS images may not
include it by default.

Remove the "user" and "password" options from the "config.yaml" file.
Those credentials are easily discoverable and insecure. The code still
hardwires bypassing the authenticating step when deploying to staging.

Move the "maintainer" line to below the "summary" one in "metadata.yaml".

README file:

- list the currently supported web browsers;
- explain the self-signed certificate workaround currently needed to
  make Firefox work;
- anonymize the EC2 addresses.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7205044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b