Issue 72020043: code review 72020043: cmd/6a: add support for nacl/amd64p32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72020043: code review 72020043: cmd/6a: add support for nacl/amd64p32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dave

Modified:
11 years, 3 months ago

Reviewers:
rsc

CC:
rsc, minux1, golang-codereviews

Visibility:
Public.

Description

cmd/6a: add support for nacl/amd64p32 Replaces CL 70000043. Switch to the amd64p32 linker model if we are building under nacl/amd64p32. No need to introduce linkarchinit() as 6a contains its own main() function.

Patch Set 1 #

Patch Set 2 : diff -r 32f0dc88f804 https://code.google.com/p/go #

Patch Set 3 : diff -r 32f0dc88f804 https://code.google.com/p/go #

Patch Set 4 : diff -r c89fe4feb24b https://code.google.com/p/go #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	src/cmd/6a/lex.c	View	1	2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 3 months ago (2014-03-06 11:21:10 UTC) #1

minux1

i think the code belongs to liblink because it's duplicated in assembler and gc.

11 years, 3 months ago (2014-03-06 17:30:01 UTC) #2

dave_cheney.net

11 years, 3 months ago (2014-03-07 05:02:41 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=72b4b258b09b ***

cmd/6a: add support for nacl/amd64p32

Replaces CL 70000043.

Switch to the amd64p32 linker model if we are building under nacl/amd64p32.

No need to introduce linkarchinit() as 6a contains its own main() function.

LGTM=rsc
R=rsc, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/72020043

Expand All Messages | Collapse All Messages